Prevent unload dialogs (...from preventing .end()) #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like the same issue that alert, confirm, etc poses. I'll fix the test conflict and pull it in. |
MasterOdin
added a commit
to MasterOdin/simulant
that referenced
this pull request
Mar 4, 2019
segment-boneyard/nightmare#825 broke being able to set beforeonload events. see: segment-boneyard/nightmare#1082
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier today I ran into this issue: #824
I resolved it by creating a modified
preload.jsthat prevents the browser from setting anyunloadorbeforeunloadhandlers. This pull request includes my modifiedpreload.jsalong with two tests that ensure that it works.